More Helpful JSON / YAML Error Messages + Minor cleanup of JSON / YAML related variables in Pattern Rules #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clarity -- passing in the actual filename + path to the JSON and YAML data functions so errors are more helpful. Related to #146
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now passing in the actual filename + path to the JSON and YAML file functions so errors are more helpful + easier to debug.
This small change makes a huge difference in projects like the Bolt Design System I run (where we're installing, versioning and publishing individual components) given that Pattern Lab by default tries to pick up deeply nested files in our component-specific
node_modulesfolders which, unless / until patched, can often cause fatal errors w/ Pattern Lab that are close to near impossible to track down otherwise.CC @aleksip